Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[user_accounts] Can set new password to be the same as current password #5439

Closed
leighevans opened this issue Oct 31, 2019 · 6 comments
Closed

[user_accounts] Can set new password to be the same as current password #5439

leighevans opened this issue Oct 31, 2019 · 6 comments
Assignees
@nicolasbrossard
Labels
Critical to release PR or issue is key for the release to which it has been assigned

Comments

@leighevans
Copy link

Test plan:
15. Check that when editing a user account it is not possible to set the password to its actual value (i.e. it needs to change).

There no currently no validation on this; you can set and save a new password to be the same as the current one
@johnsaigle
Copy link
Contributor

johnsaigle commented Nov 4, 2019 •
edited

EDIT actually I'm not sure that passwordChanged() is working correctly.

This was fixed in #5370 but the PR got merged into major... not sure what the test VM is based off of right now.

@johnsaigle
Copy link
Contributor

Also @leighevans did this occur in Edit User or My Preferences?

@johnsaigle johnsaigle mentioned this issue Nov 4, 2019
Merged
@driusan driusan added the Critical to release PR or issue is key for the release to which it has been assigned label Nov 5, 2019
@leighevans
Copy link
Author

@johnsaigle It happens in both Edit User and My Preferences

@driusan driusan mentioned this issue Nov 5, 2019
Merged
@driusan
Copy link
Collaborator

driusan commented Nov 5, 2019

According to @johnsaigle this was fixed by #5426

@driusan driusan closed this as completed Nov 5, 2019
@johnsaigle johnsaigle reopened this Nov 5, 2019
@johnsaigle
Copy link
Contributor

johnsaigle commented Nov 5, 2019 •
edited

I gave @driusan bad information. This issue is actually addressed by #5514

@driusan
Copy link
Collaborator

driusan commented Nov 11, 2019

According to @johnsaigle this was fixed by #5514

@driusan driusan closed this as completed Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasbrossard nicolasbrossard

Labels
Critical to release PR or issue is key for the release to which it has been assigned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@driusan @johnsaigle @nicolasbrossard @leighevans