Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Media] Force language selection when uploading a file. #5464

Closed
SantiagoTG opened this issue Oct 31, 2019 · 11 comments
Closed

[Media] Force language selection when uploading a file. #5464

SantiagoTG opened this issue Oct 31, 2019 · 11 comments
Assignees
Labels
Feature PR or issue introducing/requiring at least one new feature Stale PR has had no activity. Should be triaged for review or possibly closed as low priority.

Comments

@SantiagoTG
Copy link
Contributor

When uploading a file, for language input, the user should be forced to be provide an input. English can be set as a default option, and a "Not Applicable", "Multiple" or "Other" option for cases where no language is desired or includes more than one language. This is not currently the case.

@SantiagoTG SantiagoTG added Feature PR or issue introducing/requiring at least one new feature 22.0.0 TESTING labels Oct 31, 2019
@HenriRabalais
Copy link
Collaborator

PR Sent: #5577

@ridz1208
Copy link
Collaborator

@SantiagoTG why should language be required ?

Comment by dave from the linked PR:

What happens when the thing that's uploaded doesn't have a language? (ie. sleep recordings, or pre-verbal subject recordings.)

I tend to agree, and if a visit happens in multiple languages, I dont think "multiple" should be the way to handle it, I think if that feature is needed a multiselect should be used. an option "multiple" would make it impossible to query later on at dissemination

@driusan
Copy link
Collaborator

driusan commented Nov 14, 2019

"Not Applicable" handles the cases from that comment if language were required.

@HenriRabalais
Copy link
Collaborator

@ridz1208 @driusan Should this issue be closed and the PR (#5577) revised?

@driusan driusan added the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Nov 14, 2019
@SantiagoTG
Copy link
Contributor Author

I suggest that language be a requirement because otherwise the feature seems a bit pointless, or looses search functionality (if most media is not labeled, why even use the feature at all). I think having a "Not Applicable" option would solve for special cases. Multi-select also seems like a good idea if it does not have other unintended consequences (ie. for making queries or other).

@ridz1208
Copy link
Collaborator

I'll let @jesscall @sruthymathew123 make the call on this one, they know the users best.

@ridz1208 ridz1208 removed the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Nov 19, 2019
@ridz1208
Copy link
Collaborator

ridz1208 commented Nov 19, 2019

As discussed in the meeting today, this will be properly designed and implemented for a future version

@stale
Copy link

stale bot commented Jan 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale PR has had no activity. Should be triaged for review or possibly closed as low priority. label Jan 18, 2020
@stale
Copy link

stale bot commented Feb 10, 2020

The Stale label is being removed automatically because some activity has occurred or because the developers have decided that this pull request is important and should not continue to be overlooked.

@stale stale bot removed the Stale PR has had no activity. Should be triaged for review or possibly closed as low priority. label Feb 10, 2020
@stale
Copy link

stale bot commented Apr 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale PR has had no activity. Should be triaged for review or possibly closed as low priority. label Apr 10, 2020
@driusan driusan mentioned this issue Sep 24, 2021
14 tasks
@ridz1208
Copy link
Collaborator

Since 0 interest has been expressed in the last 3 years. I'm making the call and closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR or issue introducing/requiring at least one new feature Stale PR has had no activity. Should be triaged for review or possibly closed as low priority.
Projects
None yet
Development

No branches or pull requests

5 participants