Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Install] Fix error reporting when schema sourcing fails. #5472

Closed
ridz1208 opened this issue Oct 31, 2019 · 4 comments
Closed

[Install] Fix error reporting when schema sourcing fails. #5472

ridz1208 opened this issue Oct 31, 2019 · 4 comments
Assignees
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@ridz1208
Copy link
Collaborator

When running the installdb.php step of the install and a patch from the 0000-** series fails, no error is being reported to the front end, only a warning in the error log.

@ridz1208 ridz1208 added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 22.0.0 TESTING labels Oct 31, 2019
@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@maltheism we assigned you the install issues for LORIS Monday. This is one of them. If you could look at them, that would be awesome!

We know that it will be 8 issues but I have a feeling they would all be related somehow and since you played with the install, you seemed like the best person to tackle them. Let us know if you have any issues.

@maltheism
Copy link
Member

@cmadjar @ridz1208 I'm not getting any output in my error log file when running the installdb.php on the 22.0-release branch.

@driusan
Copy link
Collaborator

driusan commented Nov 1, 2019

@maltheism the error in the SQL file was fixed, so there's currently no error.. but if you modify something in the SQL schema so that it's not valid and try installdb.php you'll see that the error handling is broken

@maltheism
Copy link
Member

@driusan thanks for the explanation. I'll investigate that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

No branches or pull requests

4 participants