Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Integrity Flag] Filter link not fully working #5479

Closed
christinerogers opened this issue Nov 1, 2019 · 8 comments
Closed

[Data Integrity Flag] Filter link not fully working #5479

christinerogers opened this issue Nov 1, 2019 · 8 comments

Comments

@christinerogers
Copy link
Contributor

click on Medical History in a row with V3 ->
It does load the Data Team Helper module, filtered for the appropriate visit label V3,
but it doesn't actually filter for the Instrument name

@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@HenriRabalais could you please look into this one too next week? Thank you!

@ridz1208
Copy link
Collaborator

ridz1208 commented Nov 5, 2019

@christinerogers the data seems to be filtering correctly, the issue is, the filter at the top of the page is not displaying the instrument you filtered with. its defaulting back to all instruments

@ridz1208
Copy link
Collaborator

ridz1208 commented Nov 5, 2019

The datateamhelper's code is too horrible to debug

@cmadjar
Copy link
Collaborator

cmadjar commented Nov 8, 2019

@ridz1208 So what should be done with this issue?

@HenriRabalais
Copy link
Collaborator

@ridz1208 ?

@ridz1208
Copy link
Collaborator

@cmadjar i guess henri should take at most 30 min to figure it out. anything beyond that is a waste of time if you ask me

@HenriRabalais
Copy link
Collaborator

I spent some time on this and having a difficult time finding the source of the issue. As @ridz1208 mentioned though, the filter does seem to be working fine.

I think this module needs a major overhaul (reactification, data provisioner, etc.) and that will resolve most of the issues that this module has.

@HenriRabalais HenriRabalais removed their assignment Nov 11, 2019
@driusan driusan added the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Nov 19, 2019
@ridz1208 ridz1208 removed Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties 22.0.0 TESTING labels Nov 19, 2019
@johnsaigle
Copy link
Contributor

This module has been removed by #5824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants