Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Many endpoints can't be tested because of missing raisinbread data in Docker environment #6909

Closed
spell00 opened this issue Aug 13, 2020 · 3 comments
Closed

[API] Many endpoints can't be tested because of missing raisinbread data in Docker environment #6909

spell00 opened this issue Aug 13, 2020 · 3 comments
Assignees
@spell00 @AlexandraLivadas
Labels
API PR or issue introducing/requiring modifications to the API code RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Testing PR contains test plan or automated test code (or config files for Travis)

Comments

@spell00
Copy link
Contributor

spell00 commented Aug 13, 2020

Describe the bug
Will be completed as soon as possible.

To Reproduce

Loris/modules/api/test/LorisApiVisitsTest.php

Line 135 in c7f9b74

public function testPutCandidatesCandidVisit(): void

Will be completed as soon as possible.

What did you expect to happen?
Will be completed as soon as possible.
@spell00 spell00 added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Testing PR contains test plan or automated test code (or config files for Travis) API PR or issue introducing/requiring modifications to the API code labels Aug 13, 2020
@christinerogers christinerogers added the RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset label Aug 14, 2020
@christinerogers
Copy link
Contributor

@spell00 - can you put some time into this today? What's the minimum data we need to add to Raisinbread to solve this issue for the API testing?
cc @AlexandraLivadas could you please connect with @spell00 to fully flesh this issue out together (don't solve it yet, just clarify it really well)

i.e. Add some bullets to this issue to define what's the gap we need to close here -- so that anyone can understand clearly how big/long this task is. thanks!

@christinerogers christinerogers added Needs Documentation PR awaiting proper documentation of the changes Blocking PR should be prioritized because it is blocking the progress of another task Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties and removed Needs Documentation PR awaiting proper documentation of the changes Blocking PR should be prioritized because it is blocking the progress of another task labels Aug 27, 2020
@AlexandraLivadas
Copy link
Contributor

@christinerogers After looking at past Slack messages, this seemed to be an error with Simon's docker environment specifically and I was not able to recreate his error. If there are no objections, I will close this PR next Monday :)

@christinerogers
Copy link
Contributor

makes sense to me. closing.

@christinerogers christinerogers removed Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spell00 spell00

@AlexandraLivadas AlexandraLivadas

Labels
API PR or issue introducing/requiring modifications to the API code RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@christinerogers @spell00 @AlexandraLivadas