Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[battery manager] Get list of visits from visits table not session #8459

Closed
ridz1208 opened this issue Mar 19, 2023 · 0 comments · Fixed by #8485
Closed

[battery manager] Get list of visits from visits table not session #8459

ridz1208 opened this issue Mar 19, 2023 · 0 comments · Fixed by #8485
Assignees
@ridz1208
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@ridz1208
Copy link
Collaborator

Describe the bug
The battery manager currently only has access to visit labels already used in at least one session. it should have access to visits that have never been used
@ridz1208 ridz1208 added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Mar 19, 2023
@ridz1208 ridz1208 self-assigned this Mar 19, 2023
@ridz1208 ridz1208 mentioned this issue Mar 28, 2023
Merged
@ridz1208 ridz1208 linked a pull request Apr 14, 2023 that will close this issue
[battery_manager] use visit controller to fetch visit list #8485
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ridz1208 ridz1208

Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[battery_manager] use visit controller to fetch visit list ridz1208/Loris
1 participant
@ridz1208