Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BVL Feedback] Issues with display and closing of threads after hitting 'Close' button #5467

Closed
SantiagoTG opened this issue Oct 31, 2019 · 2 comments
Closed

[BVL Feedback] Issues with display and closing of threads after hitting 'Close' button #5467

SantiagoTG opened this issue Oct 31, 2019 · 2 comments
Assignees
@xlecours
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@SantiagoTG
Copy link
Contributor

Once a thread has been initiated, the "Open/Close" button will display as open, and a new thread will appear for the visit. If you "Close" the thread, it will display as closed, while not actually being closed.
Additionally, if you try to change the "closed" thread to "Open" again, it will continue to display as closed. Thus, closing a thread does not really close it, instead it only changes the display of the "Open/Close" button.
Refreshing the page or opening a new thread will then change all threads displayed to "Open". The "Open threads summary" will always display all threads as open.
@SantiagoTG SantiagoTG added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 22.0.0 TESTING labels Oct 31, 2019
@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@xlecours can you please look into this one? Thanks!

@xlecours xlecours mentioned this issue Nov 4, 2019
Merged
@cmadjar cmadjar added the PR sent label Nov 4, 2019
driusan pushed a commit that referenced this issue Nov 6, 2019
@xlecours @driusan
[bvl feedback] Fix thread status update (#5522)
a1f0692 
It fixes the status update and adds various error message and HTTP status codes.
While the error code are still not handled by the React app, the update now works.

Fixes #5467.
@driusan
Copy link
Collaborator

driusan commented Nov 6, 2019

Fixed by above PR

@driusan driusan closed this as completed Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xlecours xlecours

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@driusan @cmadjar @xlecours @SantiagoTG