Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Individual download #1148

Merged
merged 9 commits into from Nov 17, 2021
Merged

Individual download #1148

merged 9 commits into from Nov 17, 2021

Conversation

natacha-beck
Copy link
Contributor

Close #1133

@natacha-beck natacha-beck added this to the 6.1.0 milestone Aug 24, 2021
prioux
prioux requested changes Oct 7, 2021
View reviewed changes
Copy link
Member

@prioux prioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is buggy, if the number of columns is adjusted from 3 to 4, then you must make sure all rows are always rendered with 4 columns; you only do it in one particular render path.

@natacha-beck natacha-beck changed the base branch from master to dev November 5, 2021 15:42
prioux
prioux requested changes Nov 17, 2021
View reviewed changes
Copy link
Member

@prioux prioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested

...gins/cbrain-plugins-base/userfiles/file_collection/views/_file_collection_top_table.html.erb Outdated Show resolved Hide resolved
...in_plugins/cbrain-plugins-base/userfiles/file_collection/views/_plain_file_list_row.html.erb Show resolved Hide resolved
@prioux prioux merged commit 18600dc into aces:dev Nov 17, 2021
@natacha-beck natacha-beck deleted the individual_download branch January 23, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prioux prioux prioux requested changes

@MontrealSergiy MontrealSergiy Awaiting requested review from MontrealSergiy

Assignees
No one assigned
Labels
Enhancement Priority: Normal
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

Made files downloadable from within a file collection
2 participants
@natacha-beck @prioux