Skip to content

Commit

Permalink
fix non-ASCII input key bug
Browse files Browse the repository at this point in the history
  • Loading branch information
acevery committed Sep 4, 2012
1 parent a44d50c commit 50692ab
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion engine/table.py
Expand Up @@ -1367,7 +1367,8 @@ def _table_mode_process_key_event (self, key):
if ascii.isdigit (key.code):
self.commit_string (cond_letter_translate (unichr (key.code)))
return True
elif key.code > 127 and (not self._editor._py_mode):
elif key.code > 127 and ( unichr(key.code) not in self._valid_input_chars ) \
and(not self._editor._py_mode):
return False

if key.code == keysyms.Escape:
Expand Down

1 comment on commit 50692ab

@ueno
Copy link

@ueno ueno commented on 50692ab Sep 5, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the ASCII range check tighten to "key.code < 32 or key.code > 127"?

Related bug:
https://bugzilla.redhat.com/show_bug.cgi?id=824307

Please sign in to comment.