-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating statuses.py #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci! These are great! 🤗
A few minor changes and then I'll merge it!
statuses.py
Outdated
@@ -81,4 +81,7 @@ | |||
"Keep calm and give a hug.", | |||
"Start your day with a hug! 🤗", | |||
"Feel the presence of love wrapped up within a hug.", | |||
"Better than esperanto, hugs are a universal language.", | |||
"How can we renounce the cuddly habits, the comfort, the indolent well-being of life? - François René de Chateaubriand / Mémoires d’outre-tombe ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the quotes that are quoting someone, I like it better when the person being quoted is in their own line (see the quote on line 70 for example).
Also, there seems to have been something lost in translation? I'm not sure what the word "indolent" is meant to be here, are there maybe other suggested translations for the original French?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an old form of the same french word "indolent" (plural here), It's more of a reference to an easy going life, without trouble and pain, not "lazy" or something similar that can be of a negative connotation of a bad habit.
I could perhaps use the term "indulging" instead in the context, if it "indolent" doesn't seem fitting in English.
NOTE: The work is from 1850 so the use of such expression may have been different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It still came across as clumsy to me, so I searched and found an English translation of the work (here) and it seems like the quote goes something like "How to forego life’s tender usages, comforts, and indolent well-being?"
This seems to be less about cuddles and more about comfortable habits, so maybe let's leave this one out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is, I focused on the "cuddly" habits after reading the response to comments in the original issue #12 regarding having the word "hug" in all quotes seeming like "compulsory".
But sure, we can skip this one. I'll adjust the PR to it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating new changes based on previous review:
- Writing original author's names on different line from the quote.
- Editing translated words for alternative synonyms:
Indolent
->indulging
.
Salutary
->soothing
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, let's remove the quote from Mémoires d’outre-tombe and leave the other two.
- Sync fork to avoid conflicts from new update - deleted previously added quote from François René de Chateaubriand's Mémoires d’outre-tombe work. (translating old french work isn't easy after all x) - keeping only two newly added quotes to this project (line 87 & 88)
Alright @achasveachas , as requested in the previous review, I dropped the François René's quote. I also sync-ed the repo, since it seems it had new updates so I added the quotes on new lines to avoid merge conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, merci beaucoup! 🤗
Let me know if you have a Twitter handle so I can give you a shout-out!
Thank you for your efforts and patience! I don't have twitter but it was nice contributing to the quote bot! |
No, thank YOU! It's people like you who make it awesome 😊 |
Added 3 quotes, some french ones 👀 (translated the best I could)