triangles: Fixed TH for GHC 8.10 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change from Language.Haskell.TH. Will not work with GHC 8.8 anymore.
|
Thanks, @cjay! I think it makes more sense to add some CPP, even though I don't like contaminating another file with it :(. Could you please add it there? |
Vulkan-tutorial.com replaced chalet with viking_room. The chalet files can still be used, see Main.hs.
|
I added some CPP that works on 8.10. I haven't tested on 8.8 due to this bug with macOS that was fixed in 8.10, please test before merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change from Language.Haskell.TH. Will not work with
GHC 8.8 anymore.
This either needs conditional compilation or the cabal file should require GHC >=8.10, or to be more explicit template-haskell >=2.16.0.0