Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial implementation #1

Merged
merged 3 commits into from
Aug 6, 2022
Merged

initial implementation #1

merged 3 commits into from
Aug 6, 2022

Conversation

achou11
Copy link
Owner

@achou11 achou11 commented Aug 5, 2022 •
edited

Todo:

  • more tests with more fixtures
  • figure out what options may be useful to pass
  • adjust parameters for sharp and blurhash as we see fit

staltz
staltz approved these changes Aug 6, 2022
View reviewed changes
Copy link
Collaborator

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome as an initial commit!

@achou11 achou11 merged commit eb3c149 into main Aug 6, 2022
@achou11 achou11 deleted the ac/initial-implementation branch August 6, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staltz staltz staltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@achou11 @staltz