wallet: Avoid updating ReserveDestination::nIndex when `GetReserved…

…Destination` fails Github-Pull: bitcoin#29510 Rebased-From: 367bb7a
achow101 · Mar 1, 2024 · 7c08ccf · 7c08ccf
1 parent 1ce5acc
commit 7c08ccf
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -2596,8 +2596,10 @@ util::Result<CTxDestination> ReserveDestination::GetReservedDestination(bool int
 
     if (nIndex == -1) {
         CKeyPool keypool;
-        auto op_address = m_spk_man->GetReservedDestination(type, internal, nIndex, keypool);
+        int64_t index;
+        auto op_address = m_spk_man->GetReservedDestination(type, internal, index, keypool);
         if (!op_address) return op_address;
+        nIndex = index;
         address = *op_address;
         fInternal = keypool.fInternal;
     }