Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support Node.js v20 engine #48

Merged
merged 1 commit into from
Jun 22, 2023
Merged

chore: support Node.js v20 engine #48

merged 1 commit into from
Jun 22, 2023

Conversation

achrinza
Copy link
Owner

closes: #45

closes: #45

Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
@achrinza achrinza self-assigned this Jun 22, 2023
@achrinza achrinza merged commit 76e7471 into main Jun 22, 2023
20 checks passed
@achrinza achrinza deleted the chore/support-node20 branch June 22, 2023 05:27
@@ -16,7 +16,7 @@
"access": "public"
},
"engines": {
"node": "14 || 16 || 17 || 18 || 19"
"node": "14 || 16 || 17 || 18 || 19 || 20"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achrinza any reason why you can't put >=14 here so it will work for 21, 22, ... too?

Copy link
Owner Author

@achrinza achrinza Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jokay,

It was decided to explicitly list tested Node.js versions to give users a general recommendation on which Node.js versions are officially supported by the package.

Although some details are outdated (e.g. we now test against non-LTS versions), the rationale behind this decision can be found at #29 (comment).

Basically it stems from a disagreement between Yarn and NPM on how to treat engines.node in package.json. In this case, Yarn does provide ways to mimic NPM's more permissive approach if necessary.

We also believe most users will be sticking to LTS versions of Node.js. Since there is ample time between a Node.js release being promoted from "Current" to "LTS", we think this is a good tradeoff.

Hope it helps!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Node.js v20
2 participants