Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: support Node.js v20 engine #48

Merged
merged 1 commit into from
Jun 22, 2023
Merged

chore: support Node.js v20 engine #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
- 17
- 18
- 19
- 20
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"access": "public"
},
"engines": {
"node": "14 || 16 || 17 || 18 || 19"
"node": "14 || 16 || 17 || 18 || 19 || 20"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achrinza any reason why you can't put >=14 here so it will work for 21, 22, ... too?

Copy link
Owner Author

@achrinza achrinza Jun 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jokay,

It was decided to explicitly list tested Node.js versions to give users a general recommendation on which Node.js versions are officially supported by the package.

Although some details are outdated (e.g. we now test against non-LTS versions), the rationale behind this decision can be found at #29 (comment).

Basically it stems from a disagreement between Yarn and NPM on how to treat engines.node in package.json. In this case, Yarn does provide ways to mimic NPM's more permissive approach if necessary.

We also believe most users will be sticking to LTS versions of Node.js. Since there is ample time between a Node.js release being promoted from "Current" to "LTS", we think this is a good tradeoff.

Hope it helps!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, thank you for the clarification.

},
"dependencies": {
"@achrinza/event-pubsub": "5.0.8",
Expand Down