Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 200 Series (0xA2F0) PCH HD Audio patch. #748

Closed
wants to merge 5 commits into from
Closed

Replace 200 Series (0xA2F0) PCH HD Audio patch. #748

wants to merge 5 commits into from

Conversation

Core-i99
Copy link
Contributor

@Core-i99 Core-i99 commented Dec 24, 2021

Stop using the ugly way of patching pci id checks.

Tested and confirmed working on macOS 12.1

Lilu debug log attached:
Lilu_1.5.8_21.2.txt

Screenshot from ioreg which shows 0xA2F0 device id:
Screen Shot 2021-12-24 at 10 38 45

@vandroiy2013 Do you think it's needed to test this patch on older version then 12.1?

Stop using the ugly way of patching pci id checks.

Tested and confirmed working on macOS 12.1
@Core-i99
Copy link
Contributor Author

@Andrey1970AppleLife
What's wrong?

@vandroiy2013
Copy link
Collaborator

@TheHackGuy Please test it in older OS versions.

@Andrey1970AppleLife
Copy link
Contributor

  1. It not tested on old OS.
  2. You set min kernel Catalina.

@Andrey1970AppleLife
Copy link
Contributor

Need min kernel 16 and test on 10.12+

@Core-i99
Copy link
Contributor Author

Need min kernel 16 and test on 10.12+

I will test on all versions from 10.12 to 12.1 and then upload screenshots.

Will probably take a bit time, I think I can do this before January release.

@vandroiy2013 vandroiy2013 reopened this Dec 24, 2021
@Core-i99
Copy link
Contributor Author

Core-i99 commented Dec 24, 2021

I'm just going to comment every time I test a macOS version.

This is Big Sur 11.6.2

Screenshot:
Big Sur

Lilu log:
Lilu_1.5.8_20.6.txt

@Andrey1970AppleLife
Copy link
Contributor

You shall check also digital audio from IGPU.

@Core-i99
Copy link
Contributor Author

Core-i99 commented Dec 24, 2021

You shall check also digital audio from IGPU.

Ok.
Here is a screenshot from Big Sur 11.6.2
Screenshot 2021-12-24 at 09 58 49

I'm probably going to continue testing other macOS versions after Christmas.

@Core-i99
Copy link
Contributor Author

Core-i99 commented Dec 25, 2021

I noticed that sometimes HDMI audio only worked 1 time with the new controller patches.
Then I started investigating and tried to replace the patch with 0xA170 instead of 0x9D70, with that change HDMI audio works now every time when booting up on Catalina, Big Sur and Monterey. Commit will be created over a couple minutes.

Catalina 10.15.7 (19H15):

Screenshot:
Catalina

Lilu log:
Lilu_1.5.8_19.6.txt

And happy holidays for you guys.

@Core-i99
Copy link
Contributor Author

Mojave 10.14.4 (18E2034):

Screenshot:
Screenshot 2021-12-26 at 01 36 54

Lilu log:
Lilu_1.5.8_18.5.txt

@Core-i99
Copy link
Contributor Author

Core-i99 commented Dec 26, 2021

High Sierra 10.13.6 (17G66):

Screenshot:
Screen Shot 2021-12-26 at 03 33 15

Lilu log:
Lilu_1.5.8_17.7.txt

Problem: Can't test HDMI audio, my cpu is CFL and the iGPU is unsupported in 10.13. HDMI audio shows in Hackintool and ioreg so I guess it's fine?
@vandroiy2013 or @Andrey1970AppleLife

@Andrey1970AppleLife
Copy link
Contributor

HDMI audio shows in Hackintool and ioreg so I guess it's fine?

No, it doesn't mean what to working.
We can't accept your changes without test on KBL.
We can't allow breakage KBL.
It isn't necessary to break that that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants