Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backlight patch for icl #76

Closed
wants to merge 4 commits into from
Closed

backlight patch for icl #76

wants to merge 4 commits into from

Conversation

idalin
Copy link

@idalin idalin commented Nov 27, 2020

Copied codes from bkl patch for coffee and kaby and applied to icl

@idalin idalin mentioned this pull request Nov 27, 2020
@Lorys89
Copy link
Contributor

Lorys89 commented Nov 27, 2020

I compiled the kext and tried it in my ice lake notebook, now it works great and immediately the backlight, thanks 😘

@Lorys89
Copy link
Contributor

Lorys89 commented Nov 27, 2020

you know how to solve, at the end of loading apple you see desk for 2 seconds then disappears for 5 seconds and eventually reappears. if you try to fix🙈💪

@m0d16l14n1
Copy link

@idalin @Lorys89 like that? acidanthera/bugtracker#1329

@Lorys89
Copy link
Contributor

Lorys89 commented Nov 27, 2020

have you been able to patch HDMI output? And TYPE C to HDMI? of course on windows they both work well.

@Lorys89
Copy link
Contributor

Lorys89 commented Nov 27, 2020

@0xFireWolf @vit9696 your opinion thank you

@m0d16l14n1
Copy link

@Lorys89 read here about HDMI - Ardentwheel/OpenCore-Hasee-X57S1#3 (comment)

@vit9696
Copy link
Collaborator

vit9696 commented Nov 27, 2020

I do not like that the code is copy-pasted for a third time.

@idalin
Copy link
Author

idalin commented Nov 27, 2020

I do not like that the code is copy-pasted for a third time.

I don't like that either actually...
I just can't find a better way

@Lorys89
Copy link
Contributor

Lorys89 commented Nov 27, 2020

I do not like that the code is copy-pasted for a third time.

but I compiled with its modification and solved, maybe there will be other ways to solve.

@Andrey1970AppleLife
Copy link
Contributor

CC @hieplpvip

@thefiredragon
Copy link

thefiredragon commented Nov 27, 2020 via email

@Lorys89
Copy link
Contributor

Lorys89 commented Nov 27, 2020

Qualcuno potrebbe fornire a questo kext la patch sopra? Von meinem iPhone gesendet
...
Am 27.11.2020 um 16:09 schrieb Andrey1970AppleLife @.***>:  CC @hieplpvip — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

test this compiled kext + use this bootargs igfxcflbklt=1

WhateverGreen.kext.zip

@m0d16l14n1
Copy link

test this compiled kext + this ssdt pnlf and use this bootargs igfxcflbklt=1

@idalin @Lorys89 @vit9696

In my case i have no difference between "default" WEG/"default" ssdt and no bootarg and your compiled kext/ssdt/boot-arg. I have no problems with brightness at all. I still have only that problem with default kext or new compiled version/changes.

@thefiredragon
Copy link

Qualcuno potrebbe fornire a questo kext la patch sopra? Von meinem iPhone gesendet
...
Am 27.11.2020 um 16:09 schrieb Andrey1970AppleLife @.***>:  CC @hieplpvip — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

test this compiled kext + this ssdt pnlf and use this bootargs igfxcflbklt=1

WhateverGreen.kext.zip
SSDT-PNLF.aml.zip

It's not working for me, issue for me, max brightness is too low.
With this kext and patch after initial screen device force reboots.

@m0d16l14n1
Copy link

It's not working for me, issue for me, max brightness is too low.
With this kext and patch after initial screen device force reboots.

What's your graphics card? Ice Lake?

@thefiredragon
Copy link

thefiredragon commented Nov 28, 2020

yes, had open a ticket and also tried to use inject custom Pwm max.
But I'll sell this notebook. It's an Lenovo yoga slim 7 with i7 1065G7.
Brigthness slider is working, but the display is to dark at maximum level to work with it.
acidanthera/bugtracker#1256

@Lorys89
Copy link
Contributor

Lorys89 commented Nov 28, 2020

Qualcuno potrebbe fornire a questo kext la patch sopra? Von meinem iPhone gesendet
...
Am 27.11.2020 um 16:09 schrieb Andrey1970AppleLife @ . ***>: CC @hieplpvip - Hai ricevuto questo messaggio perché sei iscritto a questo thread. Rispondi direttamente a questa email, visualizzala su GitHub o annulla l'iscrizione.

prova questo kext compilato + questo ssdt pnlf e usa questo bootargs igfxcflbklt = 1
WhateverGreen.kext.zip
SSDT-PNLF.aml.zip

Non funziona per me, problema per me, la luminosità massima è troppo bassa.
Con questo kext e patch dopo il riavvio forzato del dispositivo della schermata iniziale.

uses only kext and bootarg and ssdt pnlf cfl, and disables kext apple blacklight smoter

@CobanRamo
Copy link

CobanRamo commented Nov 28, 2020

So with my Lenovo S340-15IIL IceLake with 1065G7 IGPU the problem is not completely solved either.
Here are my symptoms;
After sleep or after LID activation, it is simply much brighter.
After sleep or LID activation, it is just as bright as under Windows.

Bildschirmfoto 2020-11-28 um 13 26 35
Bildschirmfoto 2020-11-28 um 13 27 54
Bildschirmfoto 2020-11-28 um 13 43 46
Bildschirmfoto 2020-11-28 um 13 46 19

here is the video
sorry, link corrected ...

@Lorys89
Copy link
Contributor

Lorys89 commented Nov 28, 2020

So with my Lenovo S340-15IIL IceLake with 1065G7 IGPU the problem is not completely solved either.
Here are my symptoms;
After sleep or after LID activation, it is simply much brighter.
After sleep or LID activation, it is just as bright as under Windows.

Bildschirmfoto 2020-11-28 um 13 26 35
Bildschirmfoto 2020-11-28 um 13 27 54
Bildschirmfoto 2020-11-28 um 13 43 46
Bildschirmfoto 2020-11-28 um 13 46 19

here is the video
sorry, link corrected ...

try more igpu patch, later I'll give you my patch , ADDBOOTARGS : -wegnoegpu
and try this patch

Schermata 2020-11-28 alle 16 51 26

See my EFI --->. https://github.com/Lorys89/Dell_Vostro_5401-ICE-LAKE

@CobanRamo
Copy link

CobanRamo commented Nov 28, 2020

@Lorys89 thanks for the support.
maybe a bit oftopic but the patch doesn't help me.

I can adjust the graphic for me.
Bildschirmfoto 2020-11-28 um 17 25 18
Bildschirmfoto 2020-11-28 um 17 24 36

You use the original ID, which causes other problems for me.
I tried this one too, but it doesn't change the backlight level problem either.
Bildschirmfoto 2020-11-28 um 17 36 20

Bildschirmfoto 2020-11-28 um 17 31 32

have now switched to dark mode so that you can see the backlight level before and after Sleep or Lid.
after Sleep or Lid it is simply lighter than before.

see video ...

@thefiredragon
Copy link

@Lorys89 thanks for the support.
maybe a bit oftopic but the patch doesn't help me.

I can adjust the graphic for me.
Bildschirmfoto 2020-11-28 um 17 25 18
Bildschirmfoto 2020-11-28 um 17 24 36

You use the original ID, which causes other problems for me.
I tried this one too, but it doesn't change the backlight level problem either.
Bildschirmfoto 2020-11-28 um 17 36 20

Bildschirmfoto 2020-11-28 um 17 31 32

have now switched to dark mode so that you can see the backlight level before and after Sleep or Lid.
after Sleep or Lid it is simply lighter than before.

see video ...

How you got adavnced Features bios settings? Did you flashed hacked bios over eprom?

@CobanRamo
Copy link

@thefiredragon
No, with my Lenovo S340-15IIL IceLake I can activate DebugBios and make detailed settings.

@thefiredragon
Copy link

How you enabled DebugBios? Was this a setting ? (sorry for this off topic)

@m0d16l14n1
Copy link

m0d16l14n1 commented Nov 29, 2020

@thefiredragon

No, with my Lenovo S340-15IIL IceLake I can activate DebugBios and make detailed settings.

i got that settings too. here they are. As i see, we have some differences there, but i am not sure if it's gonna be okay to change something there except DVMT size, heh. I got that settings unlocked via modification of AMI, also guys from win-raid helped me to unlock Overclocking menu.

image

@m0d16l14n1
Copy link

m0d16l14n1 commented Nov 29, 2020

How did you unlock the hidden adviced settings of bios?

A little bit offtopic, but there are lots of guides how to properly unlock AMI based BIOS (i did it with the guide from Russian forum 4pda + guys from win-raid helped me to unlock Overclock menu). In your case - Lenovo usually using InsydeH2O bioses and there is no "guides" to that unlock. But some guys from win-raid can perform an unlock for you if you have SPI flasher (to get full dump and than flash modified). Here you can see instruction for my laptop with AMI bios. Also, sometimes vendors keep some key combos to get into debug (full) bios, but they are unknown for many laptops.

And here is example of my old Lenovo laptop InsydeH2O bios unlocked (guys from win-raid helped me out with that too)

@frozenzero123
Copy link

How did you unlock the hidden adviced settings of bios?

A little bit offtopic, but there are lots of guides how to properly unlock AMI based BIOS (i did it with the guide from Russian forum 4pda + guys from win-raid helped me to unlock Overclock menu). In your case - Lenovo usually using InsydeH2O bioses and there is no "guides" to that unlock. But some guys from win-raid can perform an unlock for you if you have SPI flasher (to get full dump and than flash modified). Here you can see instruction for my laptop with AMI bios. Also, sometimes vendors keep some key combos to get into debug (full) bios, but they are unknown for many laptops.

And here is example of my old Lenovo laptop InsydeH2O bios unlocked (guys from win-raid helped me out with that too)

Thank you! But these methods are too inconvenient for me! I want to find a way for the smart manufacturer to stay! Lenovo's equipment and "hasee" are different

@frozenzero123
Copy link

@thefiredragon
No, with my Lenovo S340-15IIL IceLake I can activate DebugBios and make detailed settings.

How did you unlock the hidden adviced settings of bios?

@CobanRamo
Copy link

It becomes too much offtopic, if you would allow private messages, I could have delivered it privately.
With Lenovo it is different from series to series.
I can offer you a German manual that I created myself.

I think that we should delete these offtopics afterwards so that we can return to the topic.

Lenovo Debug Bios Mudus.pdf

@vit9696
Copy link
Collaborator

vit9696 commented Dec 12, 2020

Implemented in master.

@vit9696 vit9696 closed this Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
8 participants