Skip to content

Commit

Permalink
ArmPlatformPkg: list module-internal header files in INF [Sources]
Browse files Browse the repository at this point in the history
The BaseTools build feature introduced for TianoCore#1804 / in commit
1fa6699 ("BaseTools: Add a checking for Sources section in INF file",
2019-06-10) logs some (non-fatal) warnings about unlisted internal header
files. List those files explicitly.

Note: header files are added in lexicographical order only if the
underlying INF file already keeps the [Sources] and [LibraryClasses]
sections in lexicographical order. Otherwise, header files are added in
rough "logical" order.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
  • Loading branch information
lersek committed Jul 22, 2019
1 parent 4cef711 commit 2a0168c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
Expand Up @@ -17,6 +17,7 @@
ENTRY_POINT = NorFlashInitialise

[Sources.common]
NorFlashDxe.h
NorFlashDxe.c
NorFlashFvbDxe.c
NorFlashBlockIoDxe.c
Expand Down
Expand Up @@ -17,6 +17,7 @@
LIBRARY_CLASS = RealTimeClockLib|DXE_RUNTIME_DRIVER

[Sources.common]
PL031RealTimeClock.h
PL031RealTimeClockLib.c

[Packages]
Expand Down
1 change: 1 addition & 0 deletions ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
Expand Up @@ -16,6 +16,7 @@

[Sources.common]
MainMPCore.c
PrePeiCore.h
PrePeiCore.c

[Sources.ARM]
Expand Down
1 change: 1 addition & 0 deletions ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
Expand Up @@ -15,6 +15,7 @@
VERSION_STRING = 1.0

[Sources.common]
PrePeiCore.h
PrePeiCore.c
MainUniCore.c

Expand Down

0 comments on commit 2a0168c

Please sign in to comment.