Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archlinux aur nodejs-soccer-go 0.4.0-2 #42

Closed
cirrusUK opened this issue Jan 17, 2019 · 7 comments
Closed

archlinux aur nodejs-soccer-go 0.4.0-2 #42

cirrusUK opened this issue Jan 17, 2019 · 7 comments

Comments

@cirrusUK
Copy link
Contributor

Expected Behavior

as shown in README.md

Actual Behavior

all commands =
✖ Fetching competition...
✖ Fetching matchday...
undefined
410

Steps to Reproduce the Problem

  1. install nodejs-soccer-go 0.4.0-2 from aur on fully updated Archlinux box
  2. execute any soccer-go command

Specifications

  • Version: 0.4.0-2
  • Platform: Archlinux
  • NodeJS Version: community/nodejs 11.6.0-1 [installed]

Is this a problem with the AUR pkg maintainer, should i flag his pkg out of date or is the problem from upstream?
Regards & thanks for the code :xd

@matei-radu
Copy link
Collaborator

matei-radu commented Jan 17, 2019

Have you tried installing it globally via NPM, just to see if it's the AUR package the one with issues (or both)?

In any case, tomorrow I'll investigate a bit on this.

@cirrusUK
Copy link
Contributor Author

cirrusUK commented Jan 18, 2019

i get errors usiing both methods
`cirrus@hawker64  /home/cirrus   node /usr/lib/node_modules/soccer-go/lib/cache/index.js  21:25:05
fs.js:121
throw err;
^

Error: EACCES: permission denied, open '/usr/lib/node_modules/soccer-go/lib/cache/.cache'
at Object.openSync (fs.js:450:3)
at Object.writeFileSync (fs.js:1212:35)
at new Cache (/usr/lib/node_modules/soccer-go/lib/cache/Cache.js:35:20)
at Object. (/usr/lib/node_modules/soccer-go/lib/cache/index.js:13:15)
at Module._compile (internal/modules/cjs/loader.js:721:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:732:10)
at Module.load (internal/modules/cjs/loader.js:620:32)
at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
at Function.Module._load (internal/modules/cjs/loader.js:552:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:774:12)
`

i will try on another arch install and report back asap, thanks.

@justinwerner
Copy link

justinwerner commented Feb 19, 2019

I have the same issue on Manjaro I3 edition (Arch based distribution). I am not sure why this is happening. Also, I tested it on my mac and am having the same result. @matt-block did you figure anything out?

@matei-radu
Copy link
Collaborator

matei-radu commented Feb 19, 2019

I had a quick look and the "issue" is in the API: we are using v1 which was rendered obsolete at the beginning of the year. From the error response:

v1 has reached it's EOL. Please migrate to v2.

We need to migrate to v2 to solve this. I can work on this but only over the weekend.

@tytondon1234
@cirrusUK (sorry for the late response)

@acifani
Copy link
Owner

acifani commented Feb 26, 2019

@cirrusUK @tytondon1234 Hi guys, apologize for being so late to the party. Our data provider has recently deprecated the APIs we were using, as @matt-block noticed.

The V2 will also have a stricter free tier and require an API key to work. I can see 2 options going forward:

  1. Move to a client/server model, with me providing the API key on the server
  2. Make users provide their own API key. This will be a bit inconvenient but also will guarantee not running into the free tier capping that a shared API key will probably cause

@acifani
Copy link
Owner

acifani commented Mar 9, 2019

@cirrusUK @tytondon1234 Hi guys, I've published version 0.5.0 on npm. AUR should follow soon, I'm in contact with the guy and I'll tell him to update his version.

I've decided to go with option 2 for now, meaning everyone has to provide its own API key and set it to SOCCER_GO_API_KEY env var. You can get it here: https://www.football-data.org/client/register

Feedback is welcome

@acifani acifani closed this as completed Mar 27, 2019
@cirrusUK
Copy link
Contributor Author

cirrusUK commented Mar 30, 2019

@acifani && @matt-block I'm most glad to report that its seems to be the AUR pkg at fault. it throws same permissions error i posted above even after exporting new API key, however installing with npm it works great, thanks for the code, and apoligies for my belated response.
regards
P.S the ascii text has a typo, it's Premier league not Premiere ;)
IIRC i fixed it with a one character edit to /src/constants/leagues.ts
- { code: 'PL', name: 'Premiere League' },
+ { code: 'PL', name: 'Premier League' },
sadly the free tier does not include the Scottish league, and it's old firm day tomorow 👍 come on the Glasgow Rangers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants