fix for large payloads #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied a fix to handle payloads more than 32kb
bhargavg
requested changes
Nov 16, 2016
| finalDataBuffer.append(responseData) | ||
| } else { | ||
| remainingLength = 0 | ||
| print("error cannot read mqtt payload") |
There was a problem hiding this comment.
I think, instead of printing, we should call self.delegate?.mqttErrorOccurred(in: self) and let the delegate do the appropriate thing.
| multiplier *= 128 | ||
| if multiplier > 128*128*128 { | ||
| return | ||
| self.queue.sync { |
There was a problem hiding this comment.
Sorry, I fail to understand why we need to dispatch the reading logic synchronously to a concurrent queue.
|
Hi, After including code for larger payloads, app crashes with "terminating with uncaught exception of type NSException"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied a fix to handle payloads more than 32kb
Fixes issue #13