Port to asyncio #102
Merged
Port to asyncio #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninjabot: add SSL/TLS support (new config option)
|
M-muh networking code! Looks good. |
| @@ -11,6 +11,7 @@ | |||
| "username": "ninjabot_un", | |||
| "realname": "ninjabot_rn" | |||
| /*"password": "server password"*/ /* Optional */ | |||
| /*"ssl": false*/ /* Optional */ | |||
There was a problem hiding this comment.
Should be true by default / 10. In all seriousness, a single non-SSL thing in a channel breaks the security of the whole channel. Let's make the bots slightly more secure, eh?
There was a problem hiding this comment.
The problem is, SSL doesn't work properly. So obviously I can't make it default or people would be asking why the bot doesn't work.
The behaviour when SSL/TLS is enabled is that a large chunk of messages are never received by the server.
There was a problem hiding this comment.
No issues with enabling SSL by default once kinks with SSL connections are ironed. But until then, nope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99, #100, and presumably #96, from the looks of things.
This would also fix #76, but in preliminary testing, the bot stopped sending messages after a while, it seems.