Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EACL 2024 videos #3296

Merged
merged 3 commits into from
May 23, 2024
Merged

Added EACL 2024 videos #3296

merged 3 commits into from
May 23, 2024

Conversation

davidstap
Copy link
Collaborator

This PR adds Underline presentation videos presented during EACL 2024.

@mjpost
Copy link
Member

mjpost commented May 15, 2024

Hi @davidstap, we've been getting a number of requests from people who had allowed recording of their videos but asked for them not to be released. Can you verify with our Underline contact that this designation is being passed to us, and is reflected in this latest import?

@davidstap
Copy link
Collaborator Author

Good point @mjpost - my guess is that this import is based on all available videos without taking into account author designations. I'll reach out to Underline.

@mjpost
Copy link
Member

mjpost commented May 22, 2024

Any response?

@davidstap
Copy link
Collaborator Author

Still waiting, I’ll send a reminder.

@davidstap
Copy link
Collaborator Author

Got a response now. It turns out that indeed, this PR includes all videos, not just videos with consent. Same issue for earlier conferences.

Underline will share the consent data. I will then sort out how to fix this, also retroactively for earlier venues.

@mjpost
Copy link
Member

mjpost commented May 22, 2024

Awesome, that sounds great—thanks, David.

@mjpost mjpost added this to the 2024Q2 milestone May 22, 2024
@davidstap
Copy link
Collaborator Author

davidstap commented May 23, 2024

I just checked and all videos in this PR have consent, so this PR is ready for review now.

I'll ask for consent data for earlier conferences, hopefully I can push the fixes this weekend Underline informed me it will take a week or so to get this data. The consent is registered in separate excel files, I'll upload these to the underline folder on our server for future reference.

@davidstap davidstap marked this pull request as ready for review May 23, 2024 06:16
Copy link
Member

@mjpost mjpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot-checked a few of these.

@mjpost mjpost merged commit babc144 into master May 23, 2024
2 checks passed
@mjpost mjpost deleted the ingest_eacl_2024_videos branch May 23, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants