Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(L10n): TESTING-translations Using what i18n already gives us #1107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jamiek-acl
Copy link
Contributor

Purpose 🚀

How we are using i18n is outdated

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2021

⚠️ No Changeset found

Latest commit: d6b0b0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

export default function ConsumingApp() {
i18n.changeLanguage("fr");
return i18n.t("timePicker.custom");
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how someone would consume @paprika/i18n

});

return i18n.t("errors.page2.saving");
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how someone would consume @paprika/i18n and provide their own Locale

Base automatically changed from testing-translations to master July 26, 2021 22:49
@tristanjasper
Copy link
Contributor

Is this affected by #1118 ?

@jamiek-acl
Copy link
Contributor Author

Is this affected by #1118 ?

No I don't think so; this PR is more of a concept. I had contacted the creators if i18next and they pointed out we were manually doing a lot of what the library does automatically. But that is because when we integrated with it, it didn't do those things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants