Dialog: fixed links not working in dialogs. Fixed jquery-archive#448 …

…- Dialog: clicking link in dialog closes dialog and doesn't do anything else
acme · Nov 16, 2010 · 791f7aa · 791f7aa
1 parent c413b2f
commit 791f7aa
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/js/jquery.mobile.dialog.js b/js/jquery.mobile.dialog.js
@@ -14,12 +14,13 @@ $.widget( "mobile.dialog", $.mobile.widget, {
 			$closeBtn = $('<a href="#" data-icon="delete" data-iconpos="notext">Close</a>');
 
 		$el.delegate("a, submit", "click submit", function(e){
-			if( e.type == "click" && ( $(e.target).closest('[data-back]') || $(e.target).closest($closeBtn) ) ){
+
+			if( e.type == "click" && ( $(e.target).closest('[data-back]')[0] || this==$closeBtn[0] ) ){
 				self.close();
 				return false;
 			}
 			//otherwise, assume we're headed somewhere new. set activepage to dialog so the transition will work
-			$.mobile.activePage = this.element;
+			$.mobile.activePage = self.element;
 		});
 
 		this.element