Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github request always triggered during --install, even when AUTO_UPGRADE is off #5200

Open
AndrewJDR opened this issue Jul 6, 2024 · 1 comment

Comments

@AndrewJDR
Copy link

Near the end of install(), there is:

  _saveaccountconf "UPGRADE_HASH" "$(_getUpgradeHash)"

This calls _getUpgradeHash which triggers a request to api.github.com. In environments where the firewall is very restricted, one may not want to enable requests to api.github.com. In this case, the request will need to time out, which can take several minutes.

It might be nice this hash request only happens if AUTO_UPGRADE is 1, for example:

if [ "$AUTO_UPGRADE" = "1" ]; then
  _saveaccountconf "UPGRADE_HASH" "$(_getUpgradeHash)"
fi

Or if this strategy is inappropriate, it'd be nice if there were some flag or environment variable that could be set to avoid this request. Thanks.

Copy link

github-actions bot commented Jul 6, 2024

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

Neilpang pushed a commit that referenced this issue Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant