dns_gcloud: allowrecord-sets list output to be separated by 'semicolon' #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcloud dns record-sets list used to separate records by comma, with version 353.0.0 the tool uses semicolons instead.
|
would you mind enabing the CI Checks ? https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test |
|
@Neilpang gcloud needs to be installed on the host/docker image, and before being able to test, an gcloud command has to be run (activating a service account). Have the tests ever been run the dns_gcloud integration? |
|
fine |
|
thanks @Neilpang ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcloud dns record-sets list used to separate records by comma, with
version 353.0.0 the tool uses semicolons instead.
This fixes #3771