Fix error handling #571
Open
Fix error handling #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differentiate between auth errors and user errors. Only dispatch logouts on auth errors.
| @@ -187,9 +188,9 @@ export const fetchService = async (url: string, requestMethod: HttpRequestMethod | |||
| }); | |||
|
|
|||
| const { status } = response; | |||
| if (status === 401 || status === 403) onFailCallback?.(); | |||
| if (status === 401 || status === 403) throw new AuthError(''); | |||
There was a problem hiding this comment.
Would it be doable to add some kind of message in here for the AuthError? I figure maybe the error field of the response might return something useful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
UserErrorandAuthErrortypes to differentiate between server errors. In the redux cleaning, I was dispatching logout on all server errors but now I only dispatch logout onAuthError.In the future, I think there should be a more unified way of handling
UserErroras generally, we just notify with an error message which can be abstracted. I've already created this kind of abstraction insrc/auth/authSlice.tsin thewithLogoutHOF which takes an async functionfand returns an async thunk that dispatches a logout whenfthrows anAuthError. I think a similar HOF could be created forUserErrorwhich sends a notify if aUserErroris thrown. If such awithNotifyHOF is created, thenwithLogoutwould probably have to be modified to allow for error chaining before creating the async thunk.