Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rubocop, assume Ruby 3.1.1 #19

Closed
wants to merge 1 commit into from
Closed

Add Rubocop, assume Ruby 3.1.1 #19

wants to merge 1 commit into from

Conversation

jcraigk
Copy link
Contributor

@jcraigk jcraigk commented Mar 27, 2022

This adds Rubocop and assumes Ruby 3.1.1 which is the latest stable Ruby as of this writing.

https://github.com/rubocop/rubocop

Before I start chipping away at the non-auto-correctable items listed in the.rubocop_todo.yml file, I thought I would get some feedback on this and make sure this is a welcome change. The .rubocop.yml contains some defaults I like, but is easy to change based on the specifics of the project and the preferences of the maintainers.

@acook
Copy link
Owner

acook commented Apr 13, 2022

Hi @jcraigk, thanks for your contributions! I really appreciate it.

I've been buried lately and somehow missed all my notifications, so apologies for the delay getting back to you.

I really like Rubocop as a concept, I've used it at pretty much every place of employment on the basis of their internal code style. For my personal projects I have a particular style I use and never got around to changing all the settings and setting it up on my projects.

A lot of the defaults go against the best practices that I have developed over the years, and there tends to be good-ish reasons for why I do them this way in my personal projects.

BUT some of my practices are out of date due to the age of some of the original code in this repo, I'll get back to you soon with my thoughts on this!

@acook
Copy link
Owner

acook commented Apr 14, 2022

I updated the Ruby version to the latest and put my thoughts on Rubocop's defaults here if you're interested: https://gist.github.com/acook/5aa0aab483b3b8e9cb385184b71a8518

@jcraigk jcraigk closed this by deleting the head repository Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants