-
Notifications
You must be signed in to change notification settings - Fork 102
Add support for metrics in containers and jobs (#830) #1758
Conversation
db0b8bb
to
83a3cf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just one line of questions for you @g-linville
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (pending rebase)
8f5f855
to
c7d119c
Compare
@@ -365,6 +365,9 @@ type Container struct { | |||
ComputeClass *string `json:"class,omitempty"` | |||
Memory *int64 `json:"memory,omitempty"` | |||
|
|||
// Metrics is available on containers and jobs, but not sidecars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you enforcing this? AML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. The AML scheme will not allow users to specify metrics in a sidecar. It has to be done at the container level.
If the metrics are available from the sidecar, it will still work as long as the port that they specify for the metrics is one that the sidecar is using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Sounds good to me.
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
7aefd27
to
05acb4e
Compare
Signed-off-by: Grant Linville <grant@acorn.io>
…io#1758) Signed-off-by: Grant Linville <grant@acorn.io>
for #830
Depends on acorn-io/aml#7
Unfortunately this change updated a ridiculous number of test files.
This new feature allows users to specify metrics inside the Acornfile like this:
Acorn runtime will create
prometheus.io/{scrape,port,path}
annotations on the resulting pods.Checklist
This is a title (#1216)
. Here's an example