Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

add project label to namespace when used within an app (#1143) #1199

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

jsilverio22
Copy link
Contributor

@jsilverio22 jsilverio22 commented Feb 3, 2023

Signed-off-by: Joshua Silverio joshua@acorn.io

Checklist

  • All relevant issues are referenced in this PR
  • The title of this PR would make a good line in the Release Note's Changelog
  • Commits are signed-off using git commit -s
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section.

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request
This PR allows users to use pre-created namespaces within the project ecosystem once an app is run within that namespace

User-Facing Change?

Does this PR introduce a user-facing change in functionality, the API or the CLI?
Users can now see the namespace as a project after app is ran
How will this change affect upgrades?

Verification and Testing

How can the changes be verified? Please provide whatever additional information necessary to help verify the proposed changes.

kubectl create namespace test
acorn run -j test .
acorn project
//should list test as a project and can do all things with test as a normal project (filter, use, rm, etc)

Are there automated tests to cover your changes?
yes

Linked Issues

#1143
Link any related issues, pull-requests, or commit hashes that are relevant to this pull request. If you are opening a PR without a corresponding issue please consider creating one first, at https://github.com/acorn-io/acorn/issues . A functional example will greatly help QA with verifying/reproducing a bug or testing new features.

@jsilverio22 jsilverio22 force-pushed the namespace-labels branch 3 times, most recently from 5584d4a to f9b8f7b Compare February 6, 2023 16:45
@jsilverio22 jsilverio22 self-assigned this Feb 6, 2023
@jsilverio22 jsilverio22 marked this pull request as ready for review February 6, 2023 17:20
@@ -82,3 +83,24 @@ func RequireNamespace(h router.Handler) router.Handler {
return h.Handle(req, resp)
})
}

func BackPopulateProjectLabel(req router.Request, resp router.Response) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name makes it sound like we are back-populating labels from another object to the namespace. I like AddAcornProjectLabel better.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that sounds better to me as well

Signed-off-by: Joshua Silverio <joshua@acorn.io>
@cloudnautique cloudnautique mentioned this pull request Jan 17, 2024
7 tasks
@iwilltry42 iwilltry42 mentioned this pull request Jan 18, 2024
7 tasks
@StrongMonkey StrongMonkey mentioned this pull request Jan 31, 2024
7 tasks
@iwilltry42 iwilltry42 mentioned this pull request Feb 19, 2024
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants