This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 100
add project label to namespace when used within an app (#1143) #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5584d4a
to
f9b8f7b
Compare
thedadams
reviewed
Feb 6, 2023
@@ -82,3 +83,24 @@ func RequireNamespace(h router.Handler) router.Handler { | |||
return h.Handle(req, resp) | |||
}) | |||
} | |||
|
|||
func BackPopulateProjectLabel(req router.Request, resp router.Response) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name makes it sound like we are back-populating labels from another object to the namespace. I like AddAcornProjectLabel
better.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that sounds better to me as well
Signed-off-by: Joshua Silverio <joshua@acorn.io>
f9b8f7b
to
aa2e499
Compare
thedadams
approved these changes
Feb 7, 2023
StrongMonkey
approved these changes
Feb 7, 2023
5 tasks
This was referenced Feb 13, 2023
6 tasks
This was referenced Feb 16, 2023
6 tasks
11 tasks
6 tasks
7 tasks
7 tasks
7 tasks
7 tasks
7 tasks
7 tasks
7 tasks
7 tasks
7 tasks
7 tasks
Merged
7 tasks
7 tasks
7 tasks
7 tasks
Merged
7 tasks
This was referenced Feb 1, 2024
Merged
7 tasks
This was referenced Feb 12, 2024
7 tasks
7 tasks
7 tasks
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Silverio joshua@acorn.io
Checklist
git commit -s
Proposed Changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request
This PR allows users to use pre-created namespaces within the project ecosystem once an app is run within that namespace
User-Facing Change?
Does this PR introduce a user-facing change in functionality, the API or the CLI?
Users can now see the namespace as a project after app is ran
How will this change affect upgrades?
Verification and Testing
How can the changes be verified? Please provide whatever additional information necessary to help verify the proposed changes.
Are there automated tests to cover your changes?
yes
Linked Issues
#1143
Link any related issues, pull-requests, or commit hashes that are relevant to this pull request. If you are opening a PR without a corresponding issue please consider creating one first, at https://github.com/acorn-io/acorn/issues . A functional example will greatly help QA with verifying/reproducing a bug or testing new features.