Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Disable NetworkPolicies by default #1785

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

g-linville
Copy link
Contributor

We need to make it very clear to users in the next release notes that this is happening.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Copy link
Contributor

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit suggestion, not blocking

lgtm

pkg/config/config.go Outdated Show resolved Hide resolved
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
@g-linville g-linville merged commit 6cd6c91 into acorn-io:main Jun 16, 2023
3 checks passed
@g-linville g-linville deleted the netpol-disable-default branch June 16, 2023 15:42
cloudnautique pushed a commit to cloudnautique/runtime that referenced this pull request Sep 28, 2023
Signed-off-by: Grant Linville <grant@acorn.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants