Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Use AppInstance instead of App for app subresouces that update (#1753) #1828

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

thedadams
Copy link
Contributor

The subresource calls for Apps in Hub get forwarded to the workload cluster. Updating the App (instead of the AppInstance) in the workload cluster will cause the App to go through validation. We don't want this to happen in the workload cluster because some objects, like compute classes, are slightly modified when they are synced up. Validating at the account-api-server level works, but not in the workload cluster.

This change will use the AppInstance for these subresources to avoid this error.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Related issue: #1753

The subresource calls for Apps in Hub get forwarded to the workload
cluster. Updating the App (instead of the AppInstance) in the workload
cluster will cause the App to go through validation. We don't want this
to happen in the workload cluster because some objects, like
compute classes, are slightly modified when they are synced up.
Validating at the account-api-server level works, but not in the
workload cluster.

This change will use the AppInstance for these subresources to avoid
this error.

Signed-off-by: Donnie Adams <donnie@acorn.io>
@thedadams thedadams merged commit 455ae84 into acorn-io:main Jun 23, 2023
2 checks passed
@thedadams thedadams deleted the gh-1753-2 branch June 23, 2023 01:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants