This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Use AppInstance instead of App for app subresouces that update (#1753) #1828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subresource calls for Apps in Hub get forwarded to the workload cluster. Updating the App (instead of the AppInstance) in the workload cluster will cause the App to go through validation. We don't want this to happen in the workload cluster because some objects, like compute classes, are slightly modified when they are synced up. Validating at the account-api-server level works, but not in the workload cluster.
This change will use the AppInstance for these subresources to avoid this error.
Checklist
This is a title (#1216)
. Here's an exampleRelated issue: #1753