Skip to content

Commit

Permalink
Revert "executer/exsystem: Warn about sleeps greater than 10 ms"
Browse files Browse the repository at this point in the history
This reverts commit 2a0d1d4.

Commit 2a0d1d4 ("ACPICA: executer/exsystem: Warn about sleeps
greater than 10 ms") made AcpiExSystemDoSleep () log a warning for
sleep times greater than 10 ms, but such sleep times are used in
power management AML because of the PCI specification requirements.

This results with logging warnings that cannot really be acted on in
any useful way which is annoying and these warnings show up in the logs
on many production systems, so revert commit 2a0d1d4.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
rafaeljw committed Jun 8, 2022
1 parent 2ebfd74 commit df896f4
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions source/components/executer/exsystem.c
Original file line number Diff line number Diff line change
Expand Up @@ -338,18 +338,6 @@ AcpiExSystemDoSleep (

AcpiExExitInterpreter ();

/*
* Warn users about excessive sleep times, so ASL code can be improved to
* use polling or similar techniques.
*/
if (HowLongMs > 10)
{
ACPI_WARNING ((AE_INFO,
"Firmware issue: Excessive sleep time (0x%8.8X%8.8X ms > 10 ms)"
" in ACPI Control Method",
ACPI_FORMAT_UINT64 (HowLongMs)));
}

/*
* For compatibility with other ACPI implementations and to prevent
* accidental deep sleeps, limit the sleep time to something reasonable.
Expand Down

0 comments on commit df896f4

Please sign in to comment.