Prevent PHPCS from scanning markdown files.

[aweingarten]

Changes proposed:

• BLT is scanning twig files which is a headache
• According to this issue the exclude patterns are necessary to prevent PHPCS from merging. The file lists.

https://www.drupal.org/node/2867601#comment-12075633

[mikemadison13]

@aweingarten you mentioned Twig in the issue but excluded md files in the PR. Was this intentional? Should we also add .twig?

[mikemadison13]

@aweingarten ping?

[aweingarten]

@mikemadison13 this was intended just to cover markdown. Title has been updated!

[mikemadison13]

@aweingarten i still only see .md files in the patch. if you want to cover just twig, .twig needs to be added

[dpagini]

There is a section above which may be a better fit...?

<arg name="ignore" value="*.css,*.md,*.txt"/>

[ba66e77]

I wonder if this pattern is too broad. I'd have to verify, but I expect that a directory named shazamd would also have its contents ignored with this. As dpagini pointed out, previous sections use a *.md pattern.

[ba66e77]

I've confirmed by suspicion. With the <exclude-pattern>*md</exclude-pattern> rule, if I put an improperly formatted css file inside a directory named shabamd (or anything else ending in md, phpcs stops seeing the css file. If I then rename the directory to shabam, phpcs sees the css file again.

[dpagini]

I just ran into a similar problem with BLT 9.0... It seems like when I have *.js files staged in git, the git commit hook is sniffing those files with PHPCS. I'm not sure why *.js is ignored from the ALL sniff, but the individual file list sniff checks those files.

...I'm wondering if the solution for that would be something similar as this?

[ba66e77]

The rule as written is too broad and will exclude things other than markdown files.

[ba66e77]

It looks to me like the test really needs to be <exclude-pattern>*\.md</exclude-pattern> to get .md files and not get other files/directories ending in md.

[mikemadison13]

this should be covered in 10.x already, see https://github.com/acquia/blt/blob/10.0.x/phpcs.xml.dist#L11