Allow blt:init:shell-alias install confirmation to be configurable when run with --no-interaction #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a necessary change for automated setups that wish to install the site alias for local developers.
lpeabody
changed the title
danepowell
approved these changes
Dec 5, 2019
danepowell
added
10.x
Backport needed
|
Rad! Figured I'd ask before you merge, but do you think it makes more sense to default |
|
I can merge it into 10.x in the BC way, then change the default when I forward-port it to 11.x (which should get a stable release in the next week or two). |
alexxed
approved these changes
Dec 7, 2019
adrianthedev
approved these changes
Dec 9, 2019
danepowell
pushed a commit
that referenced
this pull request
Dec 9, 2019
…en run with --no-interaction (#3937) * Default alias command interactions to yes. This is a necessary change for automated setups that wish to install the site alias for local developers. * Allow to set based on configuration, default to false for BC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
When issuing
blt blt:init:shell-alias --no-interaction, the shell alias should be installed rather than not installed (by default). This could be a configurable value for BC purposes. For automated project setups that run with--no-interaction, this just results in the alias not ever being setup properly.Steps to replicate the issue
blt blt:init:shell-alias --no-interaction.blt --versionand note thatbltcannot be found.Previous (bad) behavior, before applying PR
Running
blt blt:init:shell-alias --no-interactiondoes not setup the shell alias.Expected behavior, after applying PR and re-running test steps
Running
blt blt:init:shell-alias --no-interactionsets up the shell alias after setting in blt.yml:Additional details
Previous to BLT 10.x you could run
composer run-script blt-aliasand this would install the alias for you, which is what our automated setup scripts have used. However on 10.x it's no longer possible to get this behavior since the composer script was removed and the dedicated BLT command does not work in the same manner.