Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4108: Dev Desktop doctor check missing env var. #4119

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Fixes #4108: Dev Desktop doctor check missing env var. #4119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/Robo/Doctor/DevDesktopCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function performAllChecks() {
*/
protected function checkDevDesktop() {
if ($this->getInspector()->isDevDesktopInitialized()) {
if (getenv('DEVDESKTOP_DRUPAL_SETTINGS_DIR')) {
if (!getenv('DEVDESKTOP_DRUPAL_SETTINGS_DIR')) {
$this->logProblem(__FUNCTION__, [
"DevDesktop usage is enabled, but \$DEVDESKTOP_DRUPAL_SETTINGS_DIR is not set in your environmental variables.",
"",
Expand All @@ -33,16 +33,6 @@ protected function checkDevDesktop() {
"Add `export DEVDESKTOP_DRUPAL_SETTINGS_DIR=\"\$HOME/.acquia/DevDesktop/DrupalSettings\"` to ~/.bash_profile or equivalent for your system.`",
], 'error');
}

$variables_order = ini_get('variables_order');
$php_ini_file = php_ini_loaded_file();
if (!strstr($variables_order, 'E')) {
$this->logProblem(__FUNCTION__, [
"DevDesktop usage is enabled, but variables_order does support environmental variables.",
"",
"Define variables_order = \"EGPCS\" in $php_ini_file",
], 'error');
}
}
}

Expand Down