Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds bootstrap results to debug log #4128

Merged
merged 1 commit into from
Apr 23, 2020
Merged

adds bootstrap results to debug log #4128

merged 1 commit into from
Apr 23, 2020

Conversation

shelane
Copy link
Contributor

@shelane shelane commented Apr 21, 2020

Fixes #4127

Changes proposed

Add Drupal bootstrap results to the debug log output so that when running command with verbose, developers can see what the actual result was.

Steps to replicate the issue

if ($this->getInspector()->isDrupalInstalled()) {
        // Run update.
        $this->invokeCommand('artifact:update:drupal');
        $this->sendMMNotification("{$multisite} site update complete on {$environment} ({$loop} of {$total}).");
        $loop++;
      }
      else {
        $newinstall[] = $multisite;
      }

Previous (bad) behavior, before applying PR

Running the above in a custom command, I'm seeing all sites of a multisite getting put into the newinstall array. During my run, all of the sites are existing sites and the bootstrap status check should be returning successful. I need to debug further.

Expected behavior, after applying PR and re-running test steps

[debug] Drupal bootstrap results: Drupal bootstrap : Successful

@danepowell
Copy link
Contributor

Thanks for the PR!

@danepowell danepowell merged commit 503964c into acquia:11.x Apr 23, 2020
danepowell pushed a commit that referenced this pull request Apr 23, 2020
@shelane shelane deleted the 11.x branch April 23, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants