BLT-4192: Fix validate twig syntax with Drupal 9. #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4192
Changes proposed
The syntax in /core/lib/Drupal/Core/Template/TwigExtension.php has changed and the new filters are now declared with "new TwigFilter" instead of "new \Twig_SimpleFilter". Same thing for TwigFunction.
We need to update the file /src/Robo/Commands/Validate/TwigCommand.php to reflect those changes.
Steps to replicate the issue
Previous (bad) behavior, before applying PR
The TwigCommand.php is searching for "new \Twig_SimpleFilter" in Drupal core to add exception but these filters don't exist anymore.
Expected behavior, after applying PR and re-running test steps
Run the command blt validate:twig and it should contain valid syntax.