Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLT-ACSF-3: Preserve gitignore files required by ACSF #4227

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

benjifisher
Copy link
Contributor

Fixes acquia/blt-acsf#3

Motivation

The blt artifact:build command removes .gitignore files from the document root. This breaks deployment to ACSF, since the ACSF module specifically requires .gitignore files at docroot/sites/g and docroot/sites/default.

Proposed changes

Exclude the required files from being removed.

Alternatives considered

Testing steps

Prepare a Drupal 9 site for deployment to ACSF:

  • Install the packages drupal/acsf, acquia/blt-acsf, and their dependencies.
  • Run the commands blt recipes:acsf:init:drush and recipes:acsf:init:all.
  • Commit the results to Git.
  • Run the command blt artifact:deploy.
  • Update your site's code from the ACSF dashboard.

@benjifisher
Copy link
Contributor Author

I do not expect this PR to be merged in its initial form, since it may have side effects for projects that are not hosted on ACSF. At least, this gives a starting point for finding a more robust solution. Other projects that are using ACSF can apply a patch based on this PR.

@danepowell danepowell added Bug Something isn't working Major change Requires change record (often BC-breaking) labels Aug 21, 2020
@danepowell
Copy link
Contributor

Thanks a lot for the PR, this is the short-term solution I was envisioning as well. I think it's worth merging as-is to unblock ACSF users, but I also want to do more analysis to figure out how to stop this from happening again, and see if there are any better long-term solutions.

Side effects seem unlikely, I don't think .gitignore files in these directories are common, but we'll put a change record in the release notes to be safe.

@danepowell danepowell merged commit 6d35ee9 into acquia:12.x Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Major change Requires change record (often BC-breaking)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please run the acsf-init command
2 participants