Fixes #711: Adding ide:list-mine command. #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grasmash
added
dependencies
github-actions
bot
removed
the
dependencies
|
If we were going to model our command names off of Cloud API's patterns, we'd actually name the commands something like:
|
danepowell
reviewed
Nov 3, 2021
anavarre
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
./acli.phar ide:list-mine
=======================================================================
IDEs
=======================================================================
drupal7
UUID: 4d287d5c-5e7d-4daa-b7c8-0c64c44618b1
Application: MyD7App
Subscription: MyD7App
IDE URL: https://4d287d5c-5e7d-4daa-b7c8-0c64c44618b1.ide.ahdev.cloud
Web URL: https://4d287d5c-5e7d-4daa-b7c8-0c64c44618b1.web.ahdev.cloud
=======================================================================
d8isnotdead
UUID: c7c2134c-7192-4c50-800e-1c72b592edc7
Application: Main App
Subscription: Main App
IDE URL: https://c7c2134c-7192-4c50-800e-1c72b592edc7.ide.ahdev.cloud
Web URL: https://c7c2134c-7192-4c50-800e-1c72b592edc7.web.ahdev.cloud
=======================================================================
test
UUID: abab4dd0-47d8-4db9-ad39-12ab33f35adf
Application: Main App
Subscription: Main App
IDE URL: https://abab4dd0-47d8-4db9-ad39-12ab33f35adf.ide.ahdev.cloud
Web URL: https://abab4dd0-47d8-4db9-ad39-12ab33f35adf.web.ahdev.cloud
=======================================================================
=======================================================================
Co-authored-by: Dane Powell <git@danepowell.com>
danepowell
reviewed
Nov 3, 2021
| */ | ||
| protected function execute(InputInterface $input, OutputInterface $output) { | ||
| $acquia_cloud_client = $this->cloudApiClientService->getClient(); | ||
| $account_ides = $acquia_cloud_client->request('get', '/account/ides'); |
There was a problem hiding this comment.
Opened an upstream issue to add this endpoint: typhonius/acquia-php-sdk-v2#208
Not a blocker for this PR, but feel free to weigh in there.
| $table->setStyle('borderless'); | ||
| $table->setHeaders(['IDEs']); | ||
| foreach ($account_ides as $ide) { | ||
| $app_url_parts = explode('/', $ide->_links->application->href); |
There was a problem hiding this comment.
This looks like it should use the same output format as ide:info. Can we refactor this and ide:info to use a common method that accepts an array of IDE resources and pretty-prints a table?
Maybe even use it for ide:list as well, with a verbose parameter.
There was a problem hiding this comment.
Filed CLI-530 so your feedback is not lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #711
Proposed changes
ide:list-minecommand.ide:listtoide:list-app, leave anide:listfor backwards compatibility.Alternatives considered
Change behavior of
ide:listto make application argument optional.Testing steps
./bin/acli ckcide:list-appide:list-mineMerge requirements