LCH-6559: Throw an exception if search is not responding instead of r…

…eturning empty document. (#180) * LCH-6559: Throw an exception if search is not responding instead of returning empty document. * LCH-6559: Add tests for runtime exception for getEntities.
acquia · Jul 11, 2023 · 205d929 · 205d929
1 parent 27940ab
commit 205d929
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 0 deletions.
diff --git a/src/ContentHubClient.php b/src/ContentHubClient.php
@@ -355,6 +355,9 @@ public function getEntities(array $uuids) {
       ];
       $options['body'] = json_encode($query);
       $results = self::getResponseJson($this->get('_search', $options));
+      if (!isset($results['hits'])) {
+        throw new \RuntimeException('Content Hub Search endpoint is not reachable.');
+      }
       if (isset($results['hits']['total'])) {
         foreach ($results['hits']['hits'] as $key => $item) {
           $objects[] = $this->getCDFObject($item['_source']['data']);

diff --git a/test/ContentHubClientTest.php b/test/ContentHubClientTest.php
@@ -703,6 +703,47 @@ public function testGetEntitiesReturnsCDFDocumentWithEmptyObjectSetIfNothingFoun
     $this->assertCount(0, $result->getEntities());
   }
 
+  /**
+   * Tests that runtime exception is thrown.
+   *
+   * When search endpoint doesn't respond with hits.
+   *
+   * @throws \Exception
+   */
+  public function testGetEntitiesThrowsExceptionWhenSearchNotAvailable(): void {
+    $total = 50;
+    $chunk_size = 50;
+    $uuids = array_fill(0, $total, 'some-non-existing-uuid');
+
+    foreach (array_chunk($uuids, $chunk_size) as $chunk) {
+      $call_params = [
+        'size' => $chunk_size,
+        'query' => [
+          'constant_score' => [
+            'filter' => [
+              'terms' => [
+                'uuid' => $chunk,
+              ],
+            ],
+          ],
+        ],
+      ];
+      $this->ch_client
+        ->shouldReceive('get')
+        ->once()
+        ->with('_search', ['body' => json_encode($call_params)])
+        ->andReturn($this->makeMockResponse(SymfonyResponse::HTTP_OK, [],
+          json_encode([
+            'error' => 'Search not available',
+          ])));
+    }
+
+    $this->expectException(\RuntimeException::class);
+    $this->expectExceptionMessage('Content Hub Search endpoint is not reachable.');
+    $this->ch_client->getEntities($uuids);
+
+  }
+
   /**
    * @covers \Acquia\ContentHubClient\ContentHubClient::getCDFObject
    * @throws \ReflectionException