Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCH-5024: Implement new interest list endpoint. #123

Merged
merged 8 commits into from
Aug 18, 2021
Merged

LCH-5024: Implement new interest list endpoint. #123

merged 8 commits into from
Aug 18, 2021

Conversation

saxumVermes
Copy link
Contributor

No description provided.

@saxumVermes saxumVermes force-pushed the LCH-5024 branch 2 times, most recently from 0b32177 to 921340b Compare August 11, 2021 10:14
@saxumVermes saxumVermes marked this pull request as ready for review August 16, 2021 10:54
@saxumVermes saxumVermes changed the base branch from 2.x to 2.x-dashboard August 16, 2021 13:22
ankitsingh0188
ankitsingh0188 suggested changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@ankitsingh0188 ankitsingh0188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, looks good otherwise.

ankitsingh0188
ankitsingh0188 approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@ankitsingh0188 ankitsingh0188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

amangrover90
amangrover90 approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@amangrover90 amangrover90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@amangrover90 amangrover90 merged commit 5ee8c3f into 2.x-dashboard Aug 18, 2021
@amangrover90 amangrover90 deleted the LCH-5024 branch August 19, 2021 10:18
ankitsingh0188 pushed a commit that referenced this pull request Sep 6, 2021
@saxumVermes @ankitsingh0188
LCH-5024: Implement new interest list endpoint. (#123)
39f06e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jose-oliveira jose-oliveira jose-oliveira approved these changes

@ankitsingh0188 ankitsingh0188 ankitsingh0188 approved these changes

@amangrover90 amangrover90 amangrover90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saxumVermes @jose-oliveira @ankitsingh0188 @amangrover90