Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCH-5270: Added new method query entities #133

Merged
merged 6 commits into from
Oct 22, 2021
Merged

Conversation

ankitsingh0188
Copy link
Contributor

No description provided.

Copy link
Contributor

@saxumVermes saxumVermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to follow-up on the change in ObjectFastory::getCHClient() as well.

src/ContentHubClient.php Outdated Show resolved Hide resolved
src/ContentHubClient.php Outdated Show resolved Hide resolved
src/ContentHubClient.php Outdated Show resolved Hide resolved
src/ContentHubClient.php Show resolved Hide resolved
@ankitsingh0188
Copy link
Contributor Author

We need to follow-up on the change in ObjectFastory::getCHClient() as well.

Refactored the ObjectFactory::getCHClient() method and it's usage.

Copy link
Contributor

@saxumVermes saxumVermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's roll it!

Copy link
Contributor

@amangrover90 amangrover90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@amangrover90 amangrover90 merged commit e2651ec into 2.x-dashboard Oct 22, 2021
@amangrover90 amangrover90 deleted the LCH-5270 branch October 22, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants