SFSDK-38 Update sfrest to deal with restapi changes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- While these were non breaking in the restapi itself this wrapper made some assumptions on what was being input - Make sites and stack wips empty arrays rather than nil - bump the version number - rebuild docs SFSDK-38 change the signature to be an empty array SFSDK-38 Also mmake sites an empty array SFSDK-38 bump version and documetation
|
Manually checked coveralls for some reason, the coverage is 100% and https://coveralls.io/builds/35152274 and https://coveralls.io/builds/35175249 have reports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this wrapper made some assumptions on what was being input
SFSDK-38 change the signature to be an empty array
SFSDK-38 Also mmake sites an empty array
SFSDK-38 bump version and documetation