Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DG-24046 Add method to fetch sites belonging to a group. #41

Merged
merged 2 commits into from
Feb 25, 2021
Merged

DG-24046 Add method to fetch sites belonging to a group. #41

merged 2 commits into from
Feb 25, 2021

Conversation

nishatbaig
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 237

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 233: 0.0%
Covered Lines: 705
Relevant Lines: 705
💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 25, 2021 •
edited

Pull Request Test Coverage Report for Build 241

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 233: 0.0%
Covered Lines: 705
Relevant Lines: 705
💛 - Coveralls

nikgregory
nikgregory suggested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@nikgregory nikgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very minor nitpick to be ruby consistent. I am surprised that rubocop did not complain

lib/sfrest/group.rb Outdated Show resolved Hide resolved
lib/sfrest/group.rb Outdated Show resolved Hide resolved
@nikgregory nikgregory merged commit e7807ca into master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikgregory nikgregory nikgregory requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nishatbaig @coveralls @nikgregory