Allow build with systems libenet, but still support own version. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will probably merge this in the future, but there is another consideration: If enet updates their protocol, developers might accidentally compile an incompatible version. |
|
@theonlypwner Maybe adding a switch like "ENABLE_SYSTEM_ENET" ? which has to be set to yes? |
|
Adding a switch is a good idea. |
|
I compiled on debian with makefile without no errors :-) |
theonlypwner
force-pushed
the
master
branch
9 times, most recently
from
fbaff05
to
06cc372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not completely unbundle enet like #12
But will support build with a enet version provided by the system.
So like said in #195 some Linux distributions do not provide enet, that distros would then use the bundled one.
But other can use their system one.
Tested it with current release and enet7 (1.3.13) works :-)