-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed font with better UTF-8 Support #10
Comments
Roboto helped some, but mostly things improved by moving to a much smaller range of characters. The list of symbols is still too large for Roboto. More work could be done to comment out ranges that are outside Roboto's character set, find a font with more support for non-European languages, and ideally add character ranges that add more options while being unlikely to lead to user confusion (people unexperienced with the languages need to be able to tell the difference between the symbols easily). Existing ranges: image2pattern/src/image2pattern.js Lines 110 to 139 in 0f0aaed
|
Replaced Roboto with DejaVu which has support for all characters in the current space and several others. |
The black and white versions of the patter need to support using distinct symbols when possible to replace colors in the pattern. Right now the generator using a series of UTF-8 multibyte characters from selected ranges. But the default fonts in PDF from PdfKit don't support these (see foliojs/pdfkit#262). So a different font that does have those characters needs to be embedded.
The text was updated successfully, but these errors were encountered: