Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update file paths to use node's path module #8

Closed
acrosman opened this issue Oct 14, 2018 · 3 comments
Closed

Update file paths to use node's path module #8

acrosman opened this issue Oct 14, 2018 · 3 comments
Labels
good first issue Good for newcomers Hacktoberfest

Comments

@acrosman
Copy link
Owner

Several places read and write files using string concatenation instead of the Path module. The code should be updated project wide to use path.
@acrosman acrosman mentioned this issue Oct 14, 2018
Merged
@CometS1
Copy link
Contributor

CometS1 commented Oct 14, 2018

I'll work on this issue. Which files should be updated?

@acrosman
Copy link
Owner Author

Thanks.

I know there are uses in src/image2pattern.js and src/prepImage.js. It is possible there are others, but I know those are a good place to start.

@CometS1
Copy link
Contributor

CometS1 commented Oct 16, 2018

I made the changes to the two files in pull request #15. I'll keep looking through the other files for changes to be made.

acrosman added a commit that referenced this issue Oct 20, 2018
@acrosman
Merge pull request #15 from CometS1/issue-8
9d57d51 
Fix #8 - Updated image2pattern.js and prepImage.js to use node paths module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acrosman @CometS1