Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pattern): Add a bold line every N squares #5

Merged
merged 2 commits into from
Oct 14, 2018

Conversation

oktak
Copy link
Contributor

@oktak oktak commented Oct 14, 2018

TODO: fixes #3

  1. added adding bold lines for pattern
  2. since I am using Windows /_, so I added some platform specific for my test.

@acrosman
Copy link
Owner

This is a great start on #3 and is the right basic idea, but there are a couple issues.

The biggest being that ideally the count would carry over page to page, so that if printed and lined up again you could use these bold lines as counting guides all the way across the pattern. So if the page 1 is 45 squares wide, the page that lines up to be the next to the right (usually during testing that's page three) would off-set this so that first box starts shifted over the same 5 squares.

The windows file path handling is fine for now until I get around to handling #8.

@oktak
Copy link
Contributor Author

oktak commented Oct 14, 2018

I see, that means the bold lines should be continuously counting page to page?

Let me think how to implement this ;)

the counting continues page to page
@oktak
Copy link
Contributor Author

oktak commented Oct 14, 2018

3b3893d would offset the bold lines by the residue of adjacent pattern.
Please see if it works as you think :D

@acrosman acrosman merged commit 56d982a into acrosman:master Oct 14, 2018
acrosman added a commit that referenced this pull request Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a bold line every 10 squares
2 participants