This repository has been archived by the owner on Jul 12, 2019. It is now read-only.
Store sensitive environment variables in a secret. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OBK_SECRET_ variables were previously dealt with as regular OBK_ variables, thus they ended up in cleartext in the yaml files. They are now stored in a secret. Notice that Tiller admin can still see them since they are passed as values.
sbidoul
reviewed
Nov 7, 2018
chart/templates/dropdb.yaml
Outdated
| - name: PGPASSWORD | ||
| value: {{ .Values.application.database_password }} | ||
| value: {{ .Values.application.database_password | b64dec }} |
There was a problem hiding this comment.
Does this job have access to the secrets?
There was a problem hiding this comment.
No, the job is called after the release has been deleted and the secret is part of the release. So indeed, for the few seconds the job is running the password appears in cleartext in its yaml file.
So that values are flatter and at the same level that .Values.env
So that users don't need to pass already encoded variables.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OBK_SECRET_ variables were previously dealt with as regular OBK_ variables, thus they ended up in cleartext in the yaml files.
They are now stored in a secret.
Notice that Tiller admin can still see them since they are passed as values.